Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use member functions from keyring #75

Merged
merged 46 commits into from
Sep 18, 2023
Merged

Don't use member functions from keyring #75

merged 46 commits into from
Sep 18, 2023

Conversation

Powersource
Copy link
Contributor

@Powersource Powersource commented Jul 27, 2023 •
edited
Loading

Fixes #74

  • search for all uses of keystore.group.* author related functions and stop using them
  • remove registerAuthors tribes function
  • keystore.processAddMember ?

@Powersource Powersource mentioned this pull request Jul 27, 2023
Closed
6 tasks
@Powersource
Copy link
Contributor Author

all tests passing locally

mixmix
mixmix reviewed Aug 13, 2023
View reviewed changes
Copy link
Member

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Minor feedback

index.js Show resolved Hide resolved
method/group.js Show resolved Hide resolved
method/group.js Show resolved Hide resolved
method/index.js Outdated Show resolved Hide resolved
mixmix
mixmix reviewed Aug 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Powersource
Copy link
Contributor Author

Powersource commented Aug 16, 2023 •
edited
Loading

Failing tests still but committed since the commit was getting really big

Powersource
Powersource commented Aug 16, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
Powersource
Powersource commented Aug 16, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
Powersource
Powersource commented Aug 16, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
Powersource
Powersource commented Aug 17, 2023
View reviewed changes
test/api/invite.test.js Outdated Show resolved Hide resolved
mixmix
mixmix reviewed Aug 18, 2023
View reviewed changes
index.js Show resolved Hide resolved
@socket-security
Copy link

socket-security bot commented Aug 18, 2023 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ssb-crut 4.6.2...4.6.3 None +5/-5 240 kB mixmix
@tangle/reduce 5.0.4...5.0.5 None +0/-0 31.8 kB mixmix
ssb-keyring 1.1.0...1.1.1 None +11/-12 3.87 MB mixmix
ssb-keys 8.4.1...8.5.0 None +5/-6 4.13 MB staltz
scuttle-testbot 1.11.0...2.1.0 environment +20/-21 4.86 MB mixmix
sodium-native 3.2.1...3.4.1 network, environment +1/-2 3.39 MB mafintosh
tap-arc 0.3.5...0.4.0 None +4/-4 259 kB architectci
standard 17.0.0...17.1.0 None +71/-55 10.1 MB voxpelli
futoin-hkdf 1.5.2...1.5.3 None +0/-0 33.1 kB andvgal

@Powersource

This comment was marked as outdated.

Sign in to view
@Powersource

This comment was marked as outdated.

Sign in to view
@Powersource Powersource mentioned this pull request Sep 4, 2023
Open
@Powersource
Copy link
Contributor Author

created followup issue on persistence #77

@Powersource Powersource requested a review from mixmix September 5, 2023 13:58
@Powersource
Copy link
Contributor Author

i'm happy with this now, please merge if you're too

This was referenced Sep 8, 2023
Closed
Merged
@mixmix
Copy link
Member

mixmix commented Sep 12, 2023 •
edited
Loading

✔️ APPROVED

NOTE TO SELF:
This is ready to merge once we sort/ stabilise master OR get this passing.
Might make a dev branch and collect there before publishing a new release...

@socket-security
Copy link

socket-security bot commented Sep 13, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@mixmix mixmix changed the base branch from master to dev September 13, 2023 05:03
@mixmix mixmix changed the base branch from dev to master September 13, 2023 05:08
@mixmix
Copy link
Member

mixmix commented Sep 18, 2023

GOT IT @Powersource lordeeeee

@mixmix mixmix merged commit 769fb42 into master Sep 18, 2023
8 checks passed
@mixmix mixmix deleted the keyring-no-members branch September 18, 2023 04:53
@Powersource
Copy link
Contributor Author

omg wow :D

@Powersource Powersource mentioned this pull request Sep 18, 2023
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixmix mixmix Awaiting requested review from mixmix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop relying on keyring for listing members
2 participants
@Powersource @mixmix